mustafasrepo commented on code in PR #10651:
URL: https://github.com/apache/datafusion/pull/10651#discussion_r1621852333
##########
datafusion/expr/src/expr.rs:
##########
@@ -2263,7 +2267,11 @@ mod test {
let fun = find_df_window_func(name).unwrap();
let fun2 =
find_df_window_func(name.to_uppercase().as_str()).unwrap();
assert_eq!(fun, fun2);
- assert_eq!(fun.to_string(), name.to_uppercase());
+ if fun.to_string() == "first_value" || fun.to_string() ==
"last_value" {
+ assert_eq!(fun.to_string(), name);
+ } else {
+ assert_eq!(fun.to_string(), name.to_uppercase());
Review Comment:
I wonder, maybe we should treat udf names case insensitive way. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
