jayzhan211 commented on code in PR #10651: URL: https://github.com/apache/datafusion/pull/10651#discussion_r1619695089
########## datafusion/functions-aggregate/src/first_last.rs: ########## @@ -75,7 +75,8 @@ impl FirstValue { vec![ // TODO: we can introduce more strict signature that only numeric of array types are allowed TypeSignature::ArraySignature(ArrayFunctionSignature::Array), - TypeSignature::Uniform(1, NUMERICS.to_vec()), + TypeSignature::Numeric(1), + TypeSignature::Uniform(1, vec![DataType::Utf8]), Review Comment: I think we can have a better signature like PR #10697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org