jayzhan211 commented on PR #11229: URL: https://github.com/apache/datafusion/pull/11229#issuecomment-2213049428
> Hmm... ok, I think I'm going to go back to the original approach but augment it with a `count_star` function. This is similar to what duckdb does from what I can tell and seems simpler: https://github.com/duckdb/duckdb/blob/b760a3f8c049c51d79bbe1addef745661cbd30df/src/include/duckdb/function/aggregate/distributive_functions.hpp#L18-L28. > > I can add an aggregate function planner in a different PR. Not sure what exactly is `count_star` you mentioned, I think we can done these in several PR 1. Convert `count()` to `count(1)` in `plan_aggregate_function` 2. Convert `count(*)` to `count(1)` in `plan_aggregate_function ` 3. Convert `count(*)` to `count(1)` in `plan_window_function` 4. Remove convert_count_wildcard_rule Is there any displayed name issue at the first step? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
