tshauck commented on PR #11229:
URL: https://github.com/apache/datafusion/pull/11229#issuecomment-2219317160
I think we both agree on the outcome, I'm talking about the implementation
and particular how it works for the alias issues I saw. E.g. your example would
break a lot of tests though it'd produce the right answer because it changes
how the plan is represented. So the additional complexity I'm talking about is
what changes need to support that (if any) and the extent to which that makes
it a more complex issue than something like count star which may feel verbose,
but seems simple.
This is also an interesting test, because it goes straight to the logical
plan builder...
```rust
let sql_results = ctx
.sql("select count(*) from t1")
.await?
.select(vec![col("count(*)")])?
.explain(false, false)?
.collect()
.await?;
```
which maybe I missed it, but wouldn't include potentially being planned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
