tshauck commented on PR #11229: URL: https://github.com/apache/datafusion/pull/11229#issuecomment-2229514088
@jayzhan211 @alamb I've reverted this PR its original form. It adds a logical rule and updates the COUNT() function as a basis for discussion. I also explored a little bit the idea of having a specific `count_star` function. The implementation is pretty simple and it's clear what's happening, though the biggest issue is it requires updating the [`Accumulator`](https://github.com/apache/datafusion/blob/f204869ff55bb3e39cf23fc0a34ebd5021e6773f/datafusion/expr/src/accumulator.rs#L52-L213) trait so that it can handle 0 param udafs. Or at least I don't think that's currently possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
