jayzhan211 commented on PR #11229: URL: https://github.com/apache/datafusion/pull/11229#issuecomment-2219157666
> Can you say more about how this would work? If this adds complexity, it's not clear to me it's worth it vs the rule. Like why is this better than planning via a logical optimizer rule? I think the idea is to reduce the complexity, `count()`, `count(1)`, and `count(*)` are three equivalent things, we could convert them to the same thing like `count(1)` in planning stage instead of rely on optimizer rule to convert them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
