Rachelint commented on PR #16136: URL: https://github.com/apache/datafusion/pull/16136#issuecomment-2917542628
> I think this PR makes things better so approving. Nice work @Rachelint. Thanks @alamb , I think still two blocked things before merging it: - Maybe we should also compare the performance of this one with what @Dandandan mentioned https://github.com/apache/datafusion/pull/16136#discussion_r2100764581 - Run the benchmark again, and see if it always reproducable (I still have concern about no improvement in q8 of clickbench_extended, it is not as expected...). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
