alamb commented on PR #16539: URL: https://github.com/apache/datafusion/pull/16539#issuecomment-3018897937
> > The #15486 was merged fairly recently and didn't change the non-scalar code path. I think we should restore the decimal cast behavior to as it was before #15486. > > @alamb do we have an agreement on the direction proposed above? > The https://github.com/apache/datafusion/pull/15486 was merged fairly recently and didn't change the non-scalar code path. I think we should restore the decimal cast behavior to as it was before https://github.com/apache/datafusion/pull/15486. For those who -- like me -- don't want decimal fraction to get ignored, the to_timestamp seems like the alternative to use. Further, we should remove any other type-special handling in ScalarValue::cast_to_with_options, because it's likely other discrepancies. I think this makes sense to me -- ideally we can document this somewhere so we don't churn / rework the semantics again in the future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
