rluvaton commented on code in PR #18325:
URL: https://github.com/apache/datafusion/pull/18325#discussion_r2469846905
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -430,6 +431,9 @@ pub(crate) struct GroupedHashAggregateStream {
/// Execution metrics
baseline_metrics: BaselineMetrics,
+
+ /// Aggregation-specific metrics
+ group_by_metrics: GroupByMetrics,
Review Comment:
Can you also add a timer for building and searching (single timer) the the
hash table (`group_values.intern`)
or if you prefer we can leave that for later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
