kazuyukitanimura commented on code in PR #2528:
URL: https://github.com/apache/datafusion-comet/pull/2528#discussion_r2543702690
##########
.github/workflows/iceberg_spark_test.yml:
##########
@@ -156,3 +156,120 @@ jobs:
ENABLE_COMET=true ENABLE_COMET_ONHEAP=true ./gradlew
-DsparkVersions=${{ matrix.spark-version.short }} -DscalaVersion=${{
matrix.scala-version }} -DflinkVersions= -DkafkaVersions= \
:iceberg-spark:iceberg-spark-runtime-${{
matrix.spark-version.short }}_${{ matrix.scala-version }}:integrationTest \
-Pquick=true -x javadoc
+
+ iceberg-spark-rust:
+ if: contains(github.event.pull_request.title, '[iceberg]')
+ strategy:
+ matrix:
+ os: [ubuntu-24.04]
+ java-version: [11, 17]
+ iceberg-version: [{short: '1.8', full: '1.8.1'}, {short: '1.9', full:
'1.9.1'}, {short: '1.10', full: '1.10.0'}]
+ spark-version: [{short: '3.5', full: '3.5.7'}]
Review Comment:
I feel we need a test for Spark 3.4
maybe we can skip for Iceberg 1.8 instead
##########
native/Cargo.toml:
##########
@@ -34,7 +34,7 @@ edition = "2021"
rust-version = "1.86"
[workspace.dependencies]
-arrow = { version = "56.0.0", features = ["prettyprint", "ffi", "chrono-tz"] }
+arrow = { version = "56.2.0", features = ["prettyprint", "ffi", "chrono-tz"] }
Review Comment:
Is this a bug? I thought arrow ver == parquet ver always
##########
native/core/Cargo.toml:
##########
@@ -60,6 +60,7 @@ tempfile = "3.8.0"
itertools = "0.14.0"
paste = "1.0.14"
datafusion = { workspace = true, features = ["parquet_encryption"] }
+datafusion-datasource = { version = "50.3.0" }
Review Comment:
Is pinning the version necessary? may be missed for upgrading in the
future....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
