kazuyukitanimura commented on code in PR #2528:
URL: https://github.com/apache/datafusion-comet/pull/2528#discussion_r2543838330
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -196,6 +196,19 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
val nativeOp = operator2Proto(scan).get
CometNativeScan.createExec(nativeOp, scan)
+ // Fully native Iceberg scan for V2
+ // Config checks (COMET_ICEBERG_NATIVE_ENABLED, COMET_EXEC_ENABLED) are
done in CometScanRule
+ case scan: CometBatchScanExec
Review Comment:
Any possibility that iceberg_compat falls into this case?
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -807,6 +820,12 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
case scan: CometScanExec if scan.scanImpl ==
CometConf.SCAN_NATIVE_DATAFUSION =>
CometNativeScan.convert(scan, builder, childOp: _*)
+ // Fully native Iceberg scan for V2
+ case scan: CometBatchScanExec
Review Comment:
Same here
##########
spark/pom.xml:
##########
@@ -173,8 +173,52 @@ under the License.
<groupId>software.amazon.awssdk</groupId>
<artifactId>s3</artifactId>
</dependency>
+ <!-- Iceberg dependencies for testing native Iceberg scan -->
+ <!-- Note: The specific Iceberg artifact is defined in profiles below
based on Spark version -->
</dependencies>
+ <profiles>
+ <!-- Iceberg dependencies vary by Spark version (Iceberg 1.8.1 for Spark
3.x, 1.10.0 for Spark 4.0) -->
+ <profile>
+ <id>spark-3.4</id>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+
<artifactId>iceberg-spark-runtime-${spark.version.short}_${scala.binary.version}</artifactId>
+ <version>1.8.1</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+ </profile>
+
+ <profile>
+ <id>spark-3.5</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+
<artifactId>iceberg-spark-runtime-${spark.version.short}_${scala.binary.version}</artifactId>
+ <version>1.8.1</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+ </profile>
+
+ <profile>
+ <id>spark-4.0</id>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+
<artifactId>iceberg-spark-runtime-${spark.version.short}_${scala.binary.version}</artifactId>
+ <version>1.10.0</version>
Review Comment:
Are these are right combinations?
For ex 1.9 is not there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
