mbutrovich commented on code in PR #2528:
URL: https://github.com/apache/datafusion-comet/pull/2528#discussion_r2543861929
##########
spark/pom.xml:
##########
@@ -173,8 +173,52 @@ under the License.
<groupId>software.amazon.awssdk</groupId>
<artifactId>s3</artifactId>
</dependency>
+ <!-- Iceberg dependencies for testing native Iceberg scan -->
+ <!-- Note: The specific Iceberg artifact is defined in profiles below
based on Spark version -->
</dependencies>
+ <profiles>
+ <!-- Iceberg dependencies vary by Spark version (Iceberg 1.8.1 for Spark
3.x, 1.10.0 for Spark 4.0) -->
+ <profile>
+ <id>spark-3.4</id>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+
<artifactId>iceberg-spark-runtime-${spark.version.short}_${scala.binary.version}</artifactId>
+ <version>1.8.1</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+ </profile>
+
+ <profile>
+ <id>spark-3.5</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+
<artifactId>iceberg-spark-runtime-${spark.version.short}_${scala.binary.version}</artifactId>
+ <version>1.8.1</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+ </profile>
+
+ <profile>
+ <id>spark-4.0</id>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+
<artifactId>iceberg-spark-runtime-${spark.version.short}_${scala.binary.version}</artifactId>
+ <version>1.10.0</version>
Review Comment:
This is just the Iceberg version to use for `CometFuzzIcebergSuite`,
`IcebergReadFromS3Suite`, and `CometIcebergNativeSuite`. We could discuss how
many versions to test, but I don't expect major behavior differences from 1.9
if we're covering 1.8.1 and 1.10.0. We should discuss how large we want the
Iceberg test matrix to get.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
