mbutrovich commented on code in PR #2528:
URL: https://github.com/apache/datafusion-comet/pull/2528#discussion_r2543852662
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -196,6 +196,19 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
val nativeOp = operator2Proto(scan).get
CometNativeScan.createExec(nativeOp, scan)
+ // Fully native Iceberg scan for V2
+ // Config checks (COMET_ICEBERG_NATIVE_ENABLED, COMET_EXEC_ENABLED) are
done in CometScanRule
+ case scan: CometBatchScanExec
Review Comment:
Yep, just fixed this after noticing a new CI failure after enabling both
Iceberg code paths.
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -807,6 +820,12 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
case scan: CometScanExec if scan.scanImpl ==
CometConf.SCAN_NATIVE_DATAFUSION =>
CometNativeScan.convert(scan, builder, childOp: _*)
+ // Fully native Iceberg scan for V2
+ case scan: CometBatchScanExec
Review Comment:
Yep, just fixed this after noticing a new CI failure after enabling both
Iceberg code paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
