[ 
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858060#comment-16858060
 ] 

Ayush Saxena commented on HDFS-14545:
-------------------------------------

We can't rename to newConnection(), Since there is same method with similar 
params, so it throws :

{noformat}
Erasure of method newConnection(Configuration, String, UserGroupInformation, 
Class<T>) is the same as another method in type ConnectionPool
{noformat}

If you want I can pull up the whole code in  {{protected static 
ConnectionContext newConnection(Configuration conf,
      String nnAddress, UserGroupInformation ugi, Class<?> proto)}} rather than 
calling getNewConnection() . But not sure that would be a good thing to do.

{{proto.isAssignableFrom(o.getClass())}} To my Knowledge its correct only, But 
since we have hardcoded the classes corresponding to proto, the If condition 
should be true always. But seems fair enough to have this check, for being on 
the safer side.




> RBF: Router should support GetUserMappingsProtocol
> --------------------------------------------------
>
>                 Key: HDFS-14545
>                 URL: https://issues.apache.org/jira/browse/HDFS-14545
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-14545-HDFS-13891-01.patch, 
> HDFS-14545-HDFS-13891-02.patch, HDFS-14545-HDFS-13891-03.patch, 
> HDFS-14545-HDFS-13891-04.patch, HDFS-14545-HDFS-13891-05.patch, 
> HDFS-14545-HDFS-13891-06.patch, HDFS-14545-HDFS-13891-07.patch, 
> HDFS-14545-HDFS-13891-08.patch, HDFS-14545-HDFS-13891.000.patch
>
>
> We should be able to check the groups for a user from a Router.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to