[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858802#comment-16858802
]
Íñigo Goiri commented on HDFS-14545:
------------------------------------
Thanks [~ayushtkn] for the updates.
I'm good with [^HDFS-14545-HDFS-13891-09.patch] but I want to bring up a
couple things:
* The coverage is OK but could be improved. Anything easy we can do? Otherwise
we can leave as is.
* The exception handling for the constructor is kind of weird but not sure we
can do much better. The main issue is that if we have an exception we end up
returning null but we don't manage that case. It may be good to throw the
exception or improve the logging.
> RBF: Router should support GetUserMappingsProtocol
> --------------------------------------------------
>
> Key: HDFS-14545
> URL: https://issues.apache.org/jira/browse/HDFS-14545
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-14545-HDFS-13891-01.patch,
> HDFS-14545-HDFS-13891-02.patch, HDFS-14545-HDFS-13891-03.patch,
> HDFS-14545-HDFS-13891-04.patch, HDFS-14545-HDFS-13891-05.patch,
> HDFS-14545-HDFS-13891-06.patch, HDFS-14545-HDFS-13891-07.patch,
> HDFS-14545-HDFS-13891-08.patch, HDFS-14545-HDFS-13891-09.patch,
> HDFS-14545-HDFS-13891.000.patch
>
>
> We should be able to check the groups for a user from a Router.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
