[ 
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858156#comment-16858156
 ] 

Íñigo Goiri commented on HDFS-14545:
------------------------------------

True, they have the same signature.
Actually, as we only have one function it does not make much sense to split 
them into two: let's just merge them.
It should just first if the protocol exists and then just do what 
getNewConnection() does.
Let's use the template in that one.

For the isAssignable, the idea was to do the instanceof with reflection but 
doesn't look very clean; up to you.

> RBF: Router should support GetUserMappingsProtocol
> --------------------------------------------------
>
>                 Key: HDFS-14545
>                 URL: https://issues.apache.org/jira/browse/HDFS-14545
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-14545-HDFS-13891-01.patch, 
> HDFS-14545-HDFS-13891-02.patch, HDFS-14545-HDFS-13891-03.patch, 
> HDFS-14545-HDFS-13891-04.patch, HDFS-14545-HDFS-13891-05.patch, 
> HDFS-14545-HDFS-13891-06.patch, HDFS-14545-HDFS-13891-07.patch, 
> HDFS-14545-HDFS-13891-08.patch, HDFS-14545-HDFS-13891.000.patch
>
>
> We should be able to check the groups for a user from a Router.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to