[
https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858912#comment-16858912
]
Lukas Majercak commented on HDFS-14545:
---------------------------------------
ConnectionPool lines 410, 411. Would be nice to either change "clazz0" to
something like "clazzProtoPb" or remove these variables altogether.
Nitpicks:
- RouterRpcServer line 361 missing space before "="
- RouterUserProtocol line 45: you don't need .getName() there? Also maybe
separating static and non static members visually
- TestRouterUserMappings line 295: this assert length == 2 seems kinda vague,
can we pass in the actual groups ?
> RBF: Router should support GetUserMappingsProtocol
> --------------------------------------------------
>
> Key: HDFS-14545
> URL: https://issues.apache.org/jira/browse/HDFS-14545
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-14545-HDFS-13891-01.patch,
> HDFS-14545-HDFS-13891-02.patch, HDFS-14545-HDFS-13891-03.patch,
> HDFS-14545-HDFS-13891-04.patch, HDFS-14545-HDFS-13891-05.patch,
> HDFS-14545-HDFS-13891-06.patch, HDFS-14545-HDFS-13891-07.patch,
> HDFS-14545-HDFS-13891-08.patch, HDFS-14545-HDFS-13891-09.patch,
> HDFS-14545-HDFS-13891.000.patch
>
>
> We should be able to check the groups for a user from a Router.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
