On Mon, 29 Jul 2013 13:34:03 +0200, Jiří Zárevúcky <[email protected]> wrote:

On 29 July 2013 13:03, Dominik Taborsky <[email protected]> wrote:

On Mon, 29 Jul 2013 12:13:26 +0200, Jiří Zárevúcky <
[email protected]> wrote:

 Hi Dominik,

On 29 July 2013 01:32, Dominik Taborsky <[email protected]>
wrote:

 Hello folks,

[...]
hdisk: should be fine. It supports aligning on both MBR and GPT. With
GPT,
though, it does not check partition boundaries and overlapping. The
library
does support it, but hdisk does not use it.


 Why doesn't hdisk use it? I could understand if the library didn't
support
it and hdisk did the checking by itself, but the other way around it
doesn't make sense to me.


Because that's the way it's done right now. I know it's not great. If you
look at the code you might figure out why. The reason is there are three
different methods that can be used to add a partition.

I will provide a fix, don't worry. :)


I was merely wondering. :)
Thanks for working on this. I look forward to seeing it in mainline.

Thanks. Feedback like this motivates.


Btw, I noticed a typo at func_gpt.c:186.

Fixed, thanks.


Dominik

_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel

Reply via email to