Hi Dominik, On 19.8.2013 14:04, Dominik Taborsky wrote: > since nobody complained about anything in my branch, shall I push it to > mainline or would Jakub or anyone else pull it? I'd rather if I didn't > break anything... :)
Sorry for the delay, I completely forgot about this thread. There are few things to consider: 1) the build breaks for all 64-bit platforms; the first problem seems to be with formatters in libgpt.c. Take a look at: http://trac.helenos.org/wiki/Printf to see how to write portable formatters. 2) I noticed, for example in hdisk.c and libgpt.c, there are still some commented out chunks of code. Looks like the code still needs some polishing. 3) Also, you are diverging from the common cstyle in various ways. For example by indenting the case label by a tab from the level of the opening switch. 4) Finally, do you have some document (eg. a Trac wiki article) describing the install process? Thanks, Jakub _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
