On Mon, 19 Aug 2013 14:57:48 +0200, Jakub Jermar <[email protected]> wrote:
Hi Dominik,
On 19.8.2013 14:04, Dominik Taborsky wrote:
since nobody complained about anything in my branch, shall I push it to
mainline or would Jakub or anyone else pull it? I'd rather if I didn't
break anything... :)
Sorry for the delay, I completely forgot about this thread.
There are few things to consider:
1) the build breaks for all 64-bit platforms; the first problem seems to
be with formatters in libgpt.c. Take a look at:
http://trac.helenos.org/wiki/Printf
to see how to write portable formatters.
Fixed. Thanks.
2) I noticed, for example in hdisk.c and libgpt.c, there are still some
commented out chunks of code. Looks like the code still needs some
polishing.
Fixed.
3) Also, you are diverging from the common cstyle in various ways. For
example by indenting the case label by a tab from the level of the
opening switch.
I went through all of the files and fixed anything I could find. There are
some things that I leave in on purpose - sometimes I ignore 80-column line
breaking since it would make the code more unreadable. Also, sometimes I
may indent the continuing line after linebreak by more than 4 spaces. This
is again to make the code more readable.
As a side note, I dislike the current formatting of the switch constructs.
And I noticed there are several other files where indented 'case' labels
are present. I'm not saying it should change, but maybe it's not a big
deal. But while looking at the code indented label actually appears more
readable to me...
4) Finally, do you have some document (eg. a Trac wiki article)
describing the install process?
Nope, not yet.
Also, I have added a new GUID into the partition type table in global.c in
libgpt. It's the second entry, name "HelenOS System". I didn't generate
the GUID randomly. When written to disk it forms the string "HelenOS
System\0\0". Do you like it or shall I generate it (pseudo-)randomly?
(Some may say this is not a proper way to generate GUIDs, but what are the
chances of a collision? :-))
Cheers,
Dominik
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel
