On 27 August 2013 01:30, Dominik Taborsky <[email protected]> wrote: > > >> 3) Also, you are diverging from the common cstyle in various ways. For >> example by indenting the case label by a tab from the level of the >> opening switch. >> > > I went through all of the files and fixed anything I could find. There are > some things that I leave in on purpose - sometimes I ignore 80-column line > breaking since it would make the code more unreadable. Also, sometimes I > may indent the continuing line after linebreak by more than 4 spaces. This > is again to make the code more readable. > > As a side note, I dislike the current formatting of the switch constructs. > And I noticed there are several other files where indented 'case' labels > are present. I'm not saying it should change, but maybe it's not a big > deal. But while looking at the code indented label actually appears more > readable to me... > > The thing about code style is that the style you read the most usually appears more readable to you. Thus consistency often beats subjective readability. To be fair, I am not exactly spending a lot of effort to make sure my own code follows every guideline, but intentionally departing from the style should have objective reasons.
With that in mind, I do agree that 80-column lines are quite short and make some code unreadable. For those of us who can't display more columns, text editors have supported automatic line wrapping since forever, so that is not really a consideration. Just my two cents. :) -- Jirka Z.
_______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
