Ulf, My apologies. I mis-interpreted that reply.
I would commit, but I do not have commit access (no karma at all). I'm going away for a few days, but when I get back I will send a separate request to the list for karma. Thanks, Anthony On Fri, Jun 15, 2012 at 1:55 PM, Ulf Wendel <ulf.wen...@oracle.com> wrote: > Am 15.06.2012 19:31, schrieb Anthony Ferrara: > >> Ulf, >>>>> >>>>> It needs an RFC because it needs to document whether or not the other >>>>> DB drivers should also be changed. >>>> >>>> >>>> >>>> It's a PDO driver-specific change. So to me it's fairly straight >>>> forward to see that no other drivers need changing... It doesn't even >>>> hit the mysql API level... >>>> >>>> Not saying an RFC isn't needed, just that justification isn't clear to >>>> me... >>> >>> >>> >>> Go commit if you feel like the change is widely accepted, you are willing >>> to >>> explain the differences to users and no test breaks. After all its a >>> tiny, >>> little PDO driver default setting. >> >> >> I think you interpreted me wrong. I was just pointing out that this >> change would be localized to the PDO_MySQL driver. And that >> documenting whether other DB drivers should be changed is a moot >> point, since they already aren't using emulation by default... >> >> And where did the passive-agressive thing hit off? I posted it to list > > > There's a bug/feature request. Not just one, many came up over the years. > You wrote a patch. You proposed a change. Nobody rejected the change - for a > year. Its a tiny change of a driver default setting. It does not require an > RFC. > > One of the maintainers, me, didn't bring up any objections. I said what any > maintainer has to say: > > - educate users, be aware of the consequences > - make sure not to break any tests > > Another maintainer, Johannes, didn't say "no" a year ago. Nobody says "no", > !no ~ go - its your call. Stand in for your proposal, take care of the tests > and commit. > > > Ulf > > > > > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
