Hi!

> Actually, I'm going to retract my statement, and here's why:
> http://svn.wp-plugins.org/praized-community/trunk/includes/php/praized-php/PraizedCipher.php

I think breaking this code is an advantage :) That's definitely not how
php_logo_guid should be used and using it as a secure salt makes no
sense at all. To add insult to injury, it's wrapped in an if()! Please
make me unsee it.

> The rules are there to protect developers from having functions
> dropped out from under them without warning.

I know why the rules are. I just think in this case the function is
clearly abused and delaying this improvement for at least a year because
of somebody using logo guids as encryption salts makes no sense to me.

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to