[jira] [Commented] (CALCITE-2555) RexSimplify: >=(true, null) could be simplified to null

[Vladimir Sitnikov (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618713#comment-16618713
 ] 

Vladimir Sitnikov commented on CALCITE-2555:
--------------------------------------------

In the mean time, [~pzw2018], would you please update the javadoc for 
simplifyStrong?

"simplifies ... strong" does not really help since both words are present in 
the method name.

Documentation should explain what the code really does (e.g. by providing 
examples and/or corner cases).

> RexSimplify: >=(true, null) could be simplified to null
> -------------------------------------------------------
>
>                 Key: CALCITE-2555
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2555
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>              Labels: newbie
>
> {code:java}
> @Test public void simplifyComparisonWithNull() {
>   checkSimplify2(ge(trueLiteral, falseLiteral), "true", "true");
>   checkSimplify2(ge(trueLiteral, nullBool), "null", "false");
>   checkSimplify2(ge(nullBool, nullBool), "null", "false");
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)