KarmaGYZ commented on a change in pull request #11320: [FLINK-16437][runtime]
Make SlotManager allocate resource from ResourceManager at the worker
granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r388696487
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerConfiguration.java
##########
@@ -43,19 +46,23 @@
private final Time taskManagerTimeout;
private final boolean waitResultConsumedBeforeRelease;
private final boolean evenlySpreadOutSlots;
+ @Nullable
+ private final WorkerResourceSpec defaultWorkerResourceSpec;
public SlotManagerConfiguration(
Time taskManagerRequestTimeout,
Time slotRequestTimeout,
Time taskManagerTimeout,
boolean waitResultConsumedBeforeRelease,
- boolean evenlySpreadOutSlots) {
+ boolean evenlySpreadOutSlots,
+ @Nullable WorkerResourceSpec defaultWorkerResourceSpec)
{
Review comment:
Same as above. Not sure the `defaultWorkerResourceSpec` is a common field
for both static and dynamic SM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
