xintongsong commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r388721558
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnResourceManagerFactory.java
##########
@@ -81,4 +91,27 @@ public static YarnResourceManagerFactory getInstance() {
webInterfaceUrl,
resourceManagerMetricGroup);
}
+
+ @Override
+ protected CPUResource getDefaultCpus(final Configuration configuration)
{
Review comment:
Yes, I'm aware of this.
It's just we are currently having both default `TaskExecutorProcessSpec` and
default `WorkerResourceSpec`, and will migrate from the former to the latter
for the active RMs one by one. The `ActiveResourceManager#getCpuCores` could be
removed soon after all active RMs are migrated. That's why I didn't bother to
de-duplicate them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
