KarmaGYZ commented on a change in pull request #11320: [FLINK-16437][runtime]
Make SlotManager allocate resource from ResourceManager at the worker
granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r388697084
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -125,20 +126,25 @@
* */
private boolean failUnfulfillableRequest = true;
+ @Nullable
+ private final WorkerResourceSpec workerResourceSpec;
+
public SlotManagerImpl(
SlotMatchingStrategy slotMatchingStrategy,
ScheduledExecutor scheduledExecutor,
Time taskManagerRequestTimeout,
Time slotRequestTimeout,
Time taskManagerTimeout,
- boolean waitResultConsumedBeforeRelease) {
+ boolean waitResultConsumedBeforeRelease,
+ @Nullable WorkerResourceSpec workerResourceSpec) {
this.slotMatchingStrategy =
Preconditions.checkNotNull(slotMatchingStrategy);
this.scheduledExecutor =
Preconditions.checkNotNull(scheduledExecutor);
this.taskManagerRequestTimeout =
Preconditions.checkNotNull(taskManagerRequestTimeout);
this.slotRequestTimeout =
Preconditions.checkNotNull(slotRequestTimeout);
this.taskManagerTimeout =
Preconditions.checkNotNull(taskManagerTimeout);
this.waitResultConsumedBeforeRelease =
waitResultConsumedBeforeRelease;
+ this.workerResourceSpec = workerResourceSpec;
Review comment:
We could pass resource-related configs and construct the default
workerResourceSpec here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
