xintongsong commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r388723609
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ActiveResourceManagerFactory.java
##########
@@ -81,4 +83,14 @@ private static Configuration
createActiveResourceManagerConfiguration(Configurat
ClusterInformation clusterInformation,
@Nullable String webInterfaceUrl,
ResourceManagerMetricGroup resourceManagerMetricGroup) throws
Exception;
+
+ protected WorkerResourceSpec
createDefaultWorkerResourceSpec(Configuration configuration) {
Review comment:
I tend to disagree, for the following reasons.
- The default `WorkerResourceSpec` is needed for both static and dynamic
slot allocation. For dynamic allocation, we need it for scenarios where some
jobs do not provide fine grained resource requirement.
- We need the default `WorkerResourceSpec` only for active RMs, but not for
standalone RM. SM does not know which RM it runs on.
- We need the default CPU cores for creating the default
`WorkerResourceSpec`, which is depending on different configuration options per
active RM. SM does not have that information.
- According to the dependency injection principle, we should try to avoid
creating dependencies inside the component if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
