KarmaGYZ commented on a change in pull request #11320: [FLINK-16437][runtime] 
Make SlotManager allocate resource from ResourceManager at the worker 
granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r388691635
 
 

 ##########
 File path: 
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManagerFactory.java
 ##########
 @@ -98,4 +101,10 @@ public MesosResourceManagerFactory(@Nonnull MesosServices 
mesosServices, @Nonnul
                        webInterfaceUrl,
                        resourceManagerMetricGroup);
        }
+
+       @Override
+       protected CPUResource getDefaultCpus(Configuration configuration) {
 
 Review comment:
   This duplicates with `MesosTaskManagerParameters#getCpuCores`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to