Samrat002 commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3178641582
########## flink-connector-redis-streams/src/main/java/org/apache/flink/connector/redis/streams/source/split/RedisStreamsSourceSplitState.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.redis.streams.source.split; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.util.Preconditions; + +import javax.annotation.Nullable; + +import java.util.Objects; + +/** Mutable per-split state — the latest entry ID emitted by the record emitter. */ +@Internal +public class RedisStreamsSourceSplitState { + + private final RedisStreamsSourceSplit split; + @Nullable private String currentEntryId; + + public RedisStreamsSourceSplitState(RedisStreamsSourceSplit split) { + this.split = Preconditions.checkNotNull(split, "split"); + this.currentEntryId = split.getStartingEntryId(); + } + + public String getStreamKey() { + return split.getStreamKey(); + } + + @Nullable + public String getCurrentEntryId() { + return currentEntryId; Review Comment: getCurrentEntryId() is used in three test classes for state-advancement assertions. It is also the value that flows into toSplit() indirectly (via this.currentEntryId). Making it package-private would break those tests and any monitoring/metrics extension that may want to surface the current read position. It is a documented part of the internal state API. If there is a specific dead-code concern, please point to the exact callsite you believe is missing. happy to dig further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
