Samrat002 commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3178637192
########## flink-connector-redis-streams/src/main/java/org/apache/flink/connector/redis/streams/source/split/RedisStreamsSourceSplit.java: ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.redis.streams.source.split; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.connector.source.SourceSplit; +import org.apache.flink.util.Preconditions; + +import javax.annotation.Nullable; + +import java.util.Objects; + +/** + * Immutable Redis Stream split: identity is {@link #streamKey}; {@link #startingEntryId} is an + * informational resume position (canonical state lives in the Redis consumer group); + * {@link #stoppingEntryId} is non-null only in bounded mode. + */ +@Internal +public class RedisStreamsSourceSplit implements SourceSplit { + + private final String streamKey; + @Nullable private final String startingEntryId; + @Nullable private final String stoppingEntryId; + + public RedisStreamsSourceSplit( + String streamKey, @Nullable String startingEntryId, @Nullable String stoppingEntryId) { + this.streamKey = Preconditions.checkNotNull(streamKey, "streamKey"); + this.startingEntryId = startingEntryId; + this.stoppingEntryId = stoppingEntryId; + } + + public RedisStreamsSourceSplit(String streamKey) { + this(streamKey, null, null); + } + + @Override + public String splitId() { + return streamKey; + } + + public String getStreamKey() { + return streamKey; + } + + @Nullable + public String getStartingEntryId() { + return startingEntryId; + } + + @Nullable + public String getStoppingEntryId() { + return stoppingEntryId; + } + + @Override + public boolean equals(Object o) { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + RedisStreamsSourceSplit that = (RedisStreamsSourceSplit) o; + return streamKey.equals(that.streamKey); Review Comment: Split identity is stream key by design. The enumerator guarantees that at most one split exists per stream key at any point in time. Consequently: - Set<RedisStreamsSourceSplit> collections inside the enumerator use stream key as the unique identity key. - When a split is re-assigned after a task failure, the new split object (same streamKey, updated startingEntryId) must be recognised as the same logical split so it overwrites the old entry in the pending set. - If equals included startingEntryId, the same stream key with two different positions would appear as two distinct entries in a HashSet, which would break enumerator correctness. The test identityIsStreamKeyOnly explicitly verifies this invariant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
