Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435854
--- Diff: src/backend/commands/tablecmds.c ---
@@ -1174,6 +1426,44 @@ DefineExternalRelation(CreateExternalStmt
*createExtStmt)
fmtErrTblOid = InvalidOid; /* no err tbl was requested
*/
}
+ /*
+ * Parse and validate FORMAT clause.
+ *
+ * We force formatter as 'custom' if it is external hdfs protocol
+ */
+ formattype = (isExternalHdfs || isExternalMagma || isExternalHive) ?
+ 'b' : transformFormatType(createExtStmt->format);
+
+ if ((formattype == 'b') &&
--- End diff --
There should be no hard coded format name in pluggable storage framework
---
