Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436174
--- Diff: src/backend/commands/tablecmds.c ---
@@ -1210,6 +1507,16 @@ DefineExternalRelation(CreateExternalStmt
*createExtStmt)
else if (IsA(dencoding->arg, String))
{
encoding_name = strVal(dencoding->arg);
+
+ /* custom format */
+ if (!fmttype_is_text(formattype) &&
!fmttype_is_csv(formattype) &&
--- End diff --
There should be no hard coded format name in pluggable storage framework
---
