Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436164
--- Diff: src/backend/commands/tablecmds.c ---
@@ -1199,6 +1489,13 @@ DefineExternalRelation(CreateExternalStmt
*createExtStmt)
{
encoding = intVal(dencoding->arg);
encoding_name = pg_encoding_to_char(encoding);
+
+ /* custom format */
+ if (!fmttype_is_text(formattype) &&
!fmttype_is_csv(formattype))
--- End diff --
There should be no hard coded format name in pluggable storage framework
---
