taklwu commented on a change in pull request #2800:
URL: https://github.com/apache/hbase/pull/2800#discussion_r548162792
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java
##########
@@ -136,4 +140,26 @@ public static OptionalLong
getMaxSequenceIdInList(Collection<HStoreFile> sfs) {
return largestFile.isPresent() ?
StoreUtils.getFileSplitPoint(largestFile.get(), comparator)
: Optional.empty();
}
+
+ /**
+ * Returns the configured checksum algorithm.
+ * @param conf The configuration
+ * @return The checksum algorithm that is set in the configuration
+ */
+ public static ChecksumType getChecksumType(Configuration conf) {
+ String checksumName = conf.get(HConstants.CHECKSUM_TYPE_NAME);
Review comment:
will change in next commit. we put it as it's a static helper method,
IMO we're writing it in the right Utils class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
