taklwu commented on a change in pull request #2800:
URL: https://github.com/apache/hbase/pull/2800#discussion_r548317844
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -246,6 +234,8 @@
private AtomicLong compactedCellsSize = new AtomicLong();
private AtomicLong majorCompactedCellsSize = new AtomicLong();
+ private HStoreContext storeContext;
Review comment:
IMO those informative accessor/reference and final/read-only primitives
should ideally be in the context, although we're focusing on writer
(`StoreFileWriter`) related reference and may have missed few of them (e.g.
`scanInfo`) in this commit.
let's try to clarify your suggestion
1. if you see the `StoreContext` is general to be applied on most cases, are
those missing fields (e.g. `scanInfo` and final primitives) what you're trying
to point out ? if so, we can revisit and filter/add more into the
`StoreContext`
2. The scope of this `Context` is more related to
Writer(`StoreFileWriter`)/Committer(will be added), should we rename it to
`StoreWriterContext`/`StoreWriteContext` that used by those operators?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
