z-york commented on a change in pull request #2800:
URL: https://github.com/apache/hbase/pull/2800#discussion_r548200446
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -246,6 +234,8 @@
private AtomicLong compactedCellsSize = new AtomicLong();
private AtomicLong majorCompactedCellsSize = new AtomicLong();
+ private StoreContext storeContext;
Review comment:
Should this be final? I wouldn't expect you would need to change
StoreContext (the reference) after it has been initialized
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -1236,18 +1248,19 @@ private HFileContext
createFileContext(Compression.Algorithm compression,
.withIncludesMvcc(includeMVCCReadpoint)
.withIncludesTags(includesTag)
.withCompression(compression)
- .withCompressTags(family.isCompressTags())
- .withChecksumType(checksumType)
- .withBytesPerCheckSum(bytesPerChecksum)
+
.withCompressTags(getColumnFamilyDescriptor().isCompressTags())
Review comment:
Does it simplify things to be able to pass StoreContext directly to the
builders?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
