taklwu commented on a change in pull request #2800:
URL: https://github.com/apache/hbase/pull/2800#discussion_r548126048
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -246,6 +234,8 @@
private AtomicLong compactedCellsSize = new AtomicLong();
private AtomicLong majorCompactedCellsSize = new AtomicLong();
+ private HStoreContext storeContext;
Review comment:
we introduced this context for a reason. `HStore` is a big informative
object passed as a input to many file operation classes e.g. `StoreFlusher` to
get access for related information in reference, e.g. `columnFamilyDescriptor`
and `regionFileSystem`, we're trying to group those `read-only` reference such
that we don't have to always use `HStore` object in the lower classes.
Although this refactoring is the base for the upcoming patches in
HBASE-24749 that we will introduce new `StoreFileWriterFactory` and
`StoreFileCommitter`, we think this could be a good wrapper to group and limit
access for internal reference as well.
> (We need the 'H' in HStoreContext?)
we can remove the `H` from naming, will do in the next commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
