taklwu commented on a change in pull request #2800:
URL: https://github.com/apache/hbase/pull/2800#discussion_r548286395
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -1236,18 +1248,19 @@ private HFileContext
createFileContext(Compression.Algorithm compression,
.withIncludesMvcc(includeMVCCReadpoint)
.withIncludesTags(includesTag)
.withCompression(compression)
- .withCompressTags(family.isCompressTags())
- .withChecksumType(checksumType)
- .withBytesPerCheckSum(bytesPerChecksum)
+
.withCompressTags(getColumnFamilyDescriptor().isCompressTags())
Review comment:
I'd like to keep the current way that passing required fields to the
creation of `HFileContext`. Mainly `HFileContext` is also a member of the
`StoreContext` which if we pass into `StoreContext` to the creation of
`HFileContext`, it will be a loop and is very strange.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
