[
https://issues.apache.org/jira/browse/HBASE-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423348#comment-13423348
]
Elliott Clark commented on HBASE-6411:
--------------------------------------
bq.what about old MasterMetrics? Are we sure we want to replace it? I though we
want to leave it for some time
The class is still there so we're not breaking compat. All that we're doing is
changing which metrics system exports to file/jmx/ganglia. From the
conversations I've had it seems like people are fine with changing to the new
metrics system as the backing as long as we don't remove classes that could be
used externally. eg. we'll have to leave the current implementation of
MetricsHistorgram as it's possible that someone is using it outside of hbase
internal code.
(That's all just my understanding and if someone disagree's that's fine too.)
bq.Should we probably unify that? E.g. push managing "sink.ageOfLastAppliedOp"
metrics and such to xxxMetricsSource?
Stuffing dealing with the replication source uses dynamic metric names so it
relies on the more general interface and since we wanted those metrics under
the same node in jmx, I think the way we have it is fine for now; or at least
good enough to leave it as is until after your patch gets applied.
> Move Master Metrics to metrics 2
> --------------------------------
>
> Key: HBASE-6411
> URL: https://issues.apache.org/jira/browse/HBASE-6411
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6411-0.patch, HBASE-6411-1.patch,
> HBASE-6411-2.patch, HBASE-6411-3.patch, HBASE-6411_concept.patch
>
>
> Move Master Metrics to metrics 2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
