[
https://issues.apache.org/jira/browse/HBASE-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423373#comment-13423373
]
Alex Baranau commented on HBASE-6411:
-------------------------------------
Here's why I'm concerned about rewriting existing MasterMetrics class: as a
part of "revising metrics" we are likely to change existing metrics (incl.
names that we expose, esp. dependent on old stuff like MetricsTimeVaryingRate).
Though we now just copied in the initial patch all metrics from old master
metrics, they may change. That's why in my first version I just added "empty
placeholder" class with single "example" metric (cluster_requests), so that
after we revise existing we can fill in more (and they are likely to be
different from the old Master/RegionServer metrics). I guess this was discussed
a bit in HBASE-4050.
May be that is more true for RegionServer metrics though where we have a lot of
such old metrics types we don't want to support anymore. But I guess the
approach should be the same w.r.t. "overwrite or add new metrics class".
Thanx for your answers!
> Move Master Metrics to metrics 2
> --------------------------------
>
> Key: HBASE-6411
> URL: https://issues.apache.org/jira/browse/HBASE-6411
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6411-0.patch, HBASE-6411-1.patch,
> HBASE-6411-2.patch, HBASE-6411-3.patch, HBASE-6411_concept.patch
>
>
> Move Master Metrics to metrics 2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
