kgeisz commented on code in PR #8044:
URL: https://github.com/apache/hbase/pull/8044#discussion_r3090047048
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##########
@@ -4483,13 +4505,17 @@ public void onConfigurationChange(Configuration
newConf) {
}
// append the quotas observer back to the master coprocessor key
setQuotasObserver(newConf);
- // update region server coprocessor if the configuration has changed.
- if (
- CoprocessorConfigurationUtil.checkConfigurationChange(this.cpHost,
newConf,
- CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY) && !maintenanceMode
- ) {
- LOG.info("Update the master coprocessor(s) because the configuration has
changed");
Review Comment:
I got rid of this log message because the logic for determining if there was
actually a configuration change was moved to
`CoprocessorConfigurationUtil.maybeUpdateCoprocessors()`. You can find the log
message
[here](https://github.com/apache/hbase/pull/8044/changes#diff-497ef4310988f57855965f564c729f02b1aabb5d3945f4844850d688c622471aR232).
I do think I should be a little more specific in this log message. Right
now, it uses the `toString()` representation of HMaster/HRegionServer/HRegion,
which is a little vague. For example, we see this for master on a local
standalone deployment of HBase:
```
2026-04-15 16:52:51,650 INFO util.CoprocessorConfigurationUtil: Updating
coprocessors for 10.0.0.227,16000,1776296876526 because the configuration has
changed
```
I think it could say `...for Master 10.0.0.227,16000,1776296876526...`
instead of just `...for 10.0.0.227,16000,1776296876526...`
I can also leave out the `toString()` representation entirely if you think
that would be better. I can use the coprocessor configuration key to figure
out whether a master, region server, or region is what is being configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
