adnanhemani commented on code in PR #9385:
URL: https://github.com/apache/iceberg/pull/9385#discussion_r1437879000
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -50,6 +51,23 @@ public class S3FileIOProperties implements Serializable {
*/
public static final String CLIENT_FACTORY = "s3.client-factory-impl";
+ /**
+ * This property is used to enable using the S3 Access Grants product to
control authorization to
+ * S3 data. More information regarding this feature can be found at:
+ * https://aws.amazon.com/s3/features/access-grants/. The fallback-to-iam
property allows users to
+ * customize whether or not they would like their jobs fall back to the Job
Execution IAM role in
+ * case they get an Access Denied from the S3 Access Grants call. Further
documentation regarding
+ * this flag can be found in the S3 Access Grants Plugin GitHub:
+ *
+ * <p>For more details, see:
https://github.com/aws/aws-s3-accessgrants-plugin-java-v2
+ */
+ public static final String S3_ACCESS_GRANTS_ENABLED =
"s3.access-grants.enabled";
+
+ public static final boolean S3_ACCESS_GRANTS_ENABLED_DEFAULT = false;
+ public static final String S3_ACCESS_GRANTS_FALLBACK_TO_IAM_ENABLED =
Review Comment:
It is explained here:
https://github.com/apache/iceberg/pull/9385/files#diff-4e5b26d66e1235fcac2c7e808f7800b757a08e668c1c3d9fad5ec0600de45e68R58-R60
Was there something else - or further explanation required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
