adnanhemani commented on code in PR #9385:
URL: https://github.com/apache/iceberg/pull/9385#discussion_r1440008488
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -749,4 +795,23 @@ public <T extends S3ClientBuilder> void
applyEndpointConfigurations(T builder) {
builder.endpointOverride(URI.create(endpoint));
}
}
+
+ /**
+ * Add the S3 Access Grants Plugin for an S3 client.
+ *
+ * <p>Sample usage:
+ *
+ * <pre>
+ *
S3Client.builder().applyMutation(s3FileIOProperties::applyS3AccessGrantsConfigurations)
+ * </pre>
+ */
+ public <T extends S3ClientBuilder> void applyS3AccessGrantsConfigurations(T
builder) {
+ if (isS3AccessGrantsEnabled) {
+ S3AccessGrantsPlugin s3AccessGrantsPlugin =
Review Comment:
I don't think we're on the same page about this - the S3 Access Grants
plugin code is separate from the remaining AWS SDK and therefore can be treated
as any other 3rd-party dependency. But this is a moot point with the new change
I've introduced.
The size increase after these new changes are just 2.2KB (likely due to the
source code introduced itself at this point). Please let me know if these
changes are sufficient or if there are any other changes that need to be made.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
