jackye1995 commented on code in PR #9385:
URL: https://github.com/apache/iceberg/pull/9385#discussion_r1439793304
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -749,4 +795,23 @@ public <T extends S3ClientBuilder> void
applyEndpointConfigurations(T builder) {
builder.endpointOverride(URI.create(endpoint));
}
}
+
+ /**
+ * Add the S3 Access Grants Plugin for an S3 client.
+ *
+ * <p>Sample usage:
+ *
+ * <pre>
+ *
S3Client.builder().applyMutation(s3FileIOProperties::applyS3AccessGrantsConfigurations)
+ * </pre>
+ */
+ public <T extends S3ClientBuilder> void applyS3AccessGrantsConfigurations(T
builder) {
+ if (isS3AccessGrantsEnabled) {
+ S3AccessGrantsPlugin s3AccessGrantsPlugin =
Review Comment:
> but while compiling the iceberg-aws module, you'll still need both
ApacheHttpClient and UrlConnectionHttpClient classes.
Sorry my typo, we are talking about runtime dependency on a package, not
compile time. Yes compile time dependency is required.
2MB is still significant in my mind since we are really trying to minimize
bundle size as much as possible. But the more important issue is that, people
who use the current AWS bundle would get a failure unless they update their
stack to include the plugin they do not use, which is going to be a blocker for
upgrades.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
