jackye1995 commented on code in PR #9385:
URL: https://github.com/apache/iceberg/pull/9385#discussion_r1440883043
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -749,4 +795,23 @@ public <T extends S3ClientBuilder> void
applyEndpointConfigurations(T builder) {
builder.endpointOverride(URI.create(endpoint));
}
}
+
+ /**
+ * Add the S3 Access Grants Plugin for an S3 client.
+ *
+ * <p>Sample usage:
+ *
+ * <pre>
+ *
S3Client.builder().applyMutation(s3FileIOProperties::applyS3AccessGrantsConfigurations)
+ * </pre>
+ */
+ public <T extends S3ClientBuilder> void applyS3AccessGrantsConfigurations(T
builder) {
+ if (isS3AccessGrantsEnabled) {
+ S3AccessGrantsPlugin s3AccessGrantsPlugin =
Review Comment:
> the S3 Access Grants plugin code is separate from the remaining AWS SDK
and therefore can be treated as any other 3rd-party dependency. But this is a
moot point with the new change I've introduced.
I think it would be quite awkward to not make AWS SDK and AWS SDK plugin
consistent. We can add the dependency as a `implementation` as part of the
`iceberg-aws-bundle` package, but this dependency should remain `compileOnly`
in the iceberg-aws package, and make sure that users who don't have the
dependency can still use the iceberg-aws library, or any runtime jars that
bundles the library like the Spark and Flink runtime jars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
