marvinlanhenke commented on code in PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542870129
##########
crates/iceberg/src/spec/transform.rs:
##########
@@ -261,6 +270,174 @@ impl Transform {
_ => self == other,
}
}
+
+ /// Projects a given predicate according to the transformation
+ /// specified by the `Transform` instance.
+ ///
+ /// This allows predicates to be effectively applied to data
+ /// that has undergone transformation, enabling efficient querying
+ /// and filtering based on the original, untransformed data.
+ ///
+ /// # Example
+ /// Suppose, we have row filter `a = 10`, and a partition spec
+ /// `bucket(a, 37) as bs`, if one row matches `a = 10`, then its partition
+ /// value should match `bucket(10, 37) as bs`, and we project `a = 10` to
+ /// `bs = bucket(10, 37)`
+ pub fn project(&self, name: String, predicate: &BoundPredicate) ->
Result<Option<Predicate>> {
+ let func = create_transform_function(self)?;
Review Comment:
You mean, I do the check right before I call `func.transform_literal(...)`.
I have to do it in every match arm, since I need access to the `Datum` in order
to get the `PrimitiveType` as input for `result_type()`? Do I understand you
correctly?
...something like?
```Rust
let input_type = expr.literal().data_type();
self.result_type(&Type::Primitive(input_type.clone()))?;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
