marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2028045351
@Fokko @liurenjie1024 I'm having trouble understanding/ verifiying the test-case for [timestamps_day_inclusive_epoch](https://github.com/apache/iceberg/blob/d350c9b8c995a2953aa8b80a0a1fc7cadc4dd16a/api/src/test/java/org/apache/iceberg/transforms/TestTimestampsProjection.java#L168) for the case `greater than`. If I understood correctly timestamps are handled as [follows](https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/transforms/Timestamps.java#L134-L137): - call `truncateLong` -> add +1L, rewrite OP to GT_EQ and apply transformation - then `fixInclusiveTimeProjection` -> for GT_EQ -> do nothing, simply return so this would leave me with a predicate with an OP -> GT_EQ and a new literal (+1L) -> "1970-01-02T00:00:00.000000"? Why would the test then check for "1970-01-01" // I can't find the part I'm missing; Is there some part that adjusts the boundary after the fact? Or is the +1L in truncateLong not applied? This is the last part I need to port. Thanks for your help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
