liurenjie1024 commented on code in PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1543956147
##########
crates/iceberg/src/transform/mod.rs:
##########
@@ -37,6 +36,15 @@ pub trait TransformFunction: Send {
fn transform(&self, input: ArrayRef) -> Result<ArrayRef>;
/// transform_literal will take an input literal and transform it into a
new literal.
fn transform_literal(&self, input: &Datum) -> Result<Option<Datum>>;
+ /// wrapper
Review Comment:
```suggestion
/// A thin wrapper around `transform_literal` to return error even when
it's `None`.
```
##########
crates/iceberg/src/spec/transform.rs:
##########
@@ -384,6 +394,14 @@ impl Transform {
Ok(projection)
}
+ /// Check if `Transform` is applicable on datum's `PrimitiveType`
+ fn can_transform(&self, datum: &Datum) -> Result<()> {
Review Comment:
Why not just return bool directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
