marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2025357488
@liurenjie1024 I think I covered most of your suggestions. PTAL if the overall design and implementation in general is fine? ### Unresolved Issues: - [ ] How to handle PrimitiveType::Time and PrimitiveType::Timestamp for `Dates` projection and boundary adjustment - [ ] Move Transform specific logic into /transform (e.g. logic to handle Transform::Bucket projection -> /transform/bucket.rs) - [ ] Port Java testsuite to 1) I think we need to take PrimitiveType::Time and convert it to PrimitiveType::Date and then adjust the boundary. If this is correct, I still havent found a way to convert between those types. Perhaps someone can point me in the right direction? --- *due to easter-holidays (and my two children) - I can probably do only some minimal work on this over the weekend -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
